search

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
274 stars 63 forks source link

complete workbench theme #2

Closed 3ximus closed 6 years ago

3ximus commented 6 years ago

Hey man, its me again. I wanted to fix some of the issues with python syntax highlighting and ended up doing a complete overall of the workbench settings... Now I'm tired of this and can't fix the stuff I wanted in the first place. But here it is, I think it looks better now, tell me what you think. Also, do you want to rename the extension to simply "Gruvbox"? Its the best one in the marketplace and it looks more clean. I went ahead and did that on the last commit

3ximus commented 6 years ago

Ok... I went ahead and added better support for Python, Java, C and Json and organized the syntax part a little bit because it was a little bit messy. I hope I'm not overstepping on your repo here. If you prefer I can use my fork. Anyway, give me your feedback on this..

jdinhify commented 6 years ago

Nice, thanks for this @3ximus . I'm checking out your code and liking it so far. I'll put in some comments & suggestions shortly.

Regarding the naming, I think renaming the extension to just 'Gruvbox' might create confusion as the original theme consists of 6 variants and this is only 1 of them (Dark + Medium Contrast - hence the original name). Changing the name to 'Gruvbox Dark Medium' could be an option?

3ximus commented 6 years ago

I did a few changes to the stuff you pointed, see if you like them