Closed serend1p1ty closed 4 years ago
Now it's default ugly red.
Thanks for reporting this @ppnman 👌 I don't use peekView often though, so not sure what would be the best background, would you be able to suggest a colour?
What do you think of the color(#ac6913) ?
Or this(#23395C)?
Or you can reference other colortheme.
BTW, your gruvbox colorscheme is great, I love it!
BTW, I suggest that the foreground of the item seleceted should be lighter than other entries.
Like this:
(Solarized Dark)
Now it is darker than other entries.
(Gruvbox Medium)
@jdinhify So the final effect is:
// PEEK VIEW
"peekView.border": "#3c3836",
"peekViewEditor.background": "#3c383650",
"peekViewEditorGutter.background": "#3c383650",
"peekViewEditor.matchHighlightBackground": "#ac6913", #Modified
"peekViewResult.background": "#3c383650",
"peekViewResult.fileForeground": "#ebdbb2",
"peekViewResult.matchHighlightBackground": "#8ec07c30",
"peekViewResult.selectionBackground": "#8ec07c30",
"peekViewResult.selectionForeground": "#FFFFFF", #Modified
"peekViewTitle.background": "#3c383650",
"peekViewTitleDescription.foreground": "#bdae93",
"peekViewTitleLabel.foreground": "#ebdbb2",
thanks @ppnman, the color look cool, but I think it's better to stick with the colors in gruvbox palette, would you be able to give the colors.txt a try https://github.com/jdinhify/vscode-theme-gruvbox/blob/master/colors.txt
try
"peekViewEditor.matchHighlightBackground": "#fe801980",
"peekViewResult.selectionForeground": "#fbf1c7"
note that you can use 2 chars (00 -> ff) after the color code to specify the alpha, eg. #fe801980
is the orange 2 in colors.txt
(fe8019
) with 80
as alpha
@jdinhify Very good, I like it.
Thanks @ppnman , would you be able to submit a PR for it? I'm happy to do it if you can't.
It'd be great if you can do for other variants, but no pressure, I can have a follow up commit to address other variants
@jdinhify I am really sorry that I just saw your reply. There are so many things going on there days so that I have no time to browse GitHub. Of course, I am glad to submit a PR for it. But maybe it takes one week to finish it because I need to consider what color is better in light colorscheme.
That's alright @ppnman , please take as much time as you need.
Thank you
I am sorry to close the issue because I don't use vscode anymore. BTW, both the plugin and author are great.