search

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
274 stars 63 forks source link

Scrollbar suggestion #4

Closed zer09 closed 6 years ago

zer09 commented 6 years ago

Add more contrast on scrollbar "bar" when the mouse is hovered on the scrollbar area. Because you cant "barely" see the scrollbar unless you hit the exact position of it.

Thanks.

jdinhify commented 6 years ago

Currently, when you hover over the small bar, it'll be highlighted. I'm thinking what you're suggesting is doing the same when hovering over the whole scrollbar area?

zer09 commented 6 years ago

Yeah, you're right. Sometimes on a long documents, I can't spot the small bar easily.

jdinhify commented 6 years ago

Cool, I just had a look and there's no option to change the slider on hovering over the whole scrollbar area. However, I agree with what you suggest though, making that a bit more visible would be helpful, so I'll make the default slider background brighter regardless of whether it's being hovered over or not, hope that would help.

zer09 commented 6 years ago

Thanks, I will appreciate that so much. Actually I tried many themes just because of that, but I am still coming back to your theme.

jdinhify commented 6 years ago

Thanks, I didn't need to use the scrollbar much to realise the issue.

Anyway, the change is done in 0e1691d.

Your vscode should be able to update the extension now. Please try it and let me know what you think

zer09 commented 6 years ago

WOW that's quick. I already update it, and I like it.

Thank you so much.