jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
274 stars 63 forks source link

Bracket pair colouriser support #43

Closed johannesrld closed 2 years ago

johannesrld commented 2 years ago

vscode recently introduced editor.bracketPairColorization.enabled as an option (check this update)

these can be customised with the settings editorBracketHighlight.foregroundx with the trailing x being replace by the numbers 1-6 and editorBracketHighlight.unexpectedBracket.foreground for singular brackets not in a pair

jdinhify commented 2 years ago

Thanks @tauin

I'm curious what sort of colours would you use. Obviously they should be in the gruvbox palette (https://github.com/morhetz/gruvbox), but the question is more about the brightness: if you're using dark mode, would you use the same or darker colours for the brackets?

Tuuuukka commented 2 years ago

I've been using these for the Gruvbox Dark Medium for a while now:

    // BRACKETS
    "editorBracketHighlight.foreground1": "#fabd2f",
    "editorBracketHighlight.foreground2": "#d3869b",
    "editorBracketHighlight.foreground3": "#83a598",
    "editorBracketHighlight.foreground4": "#b8bb26",
    "editorBracketHighlight.foreground6": "#8ec07c",
    "editorBracketHighlight.unexpectedBracket.foreground": "#fb4934"

image

Don't know if they're perfect, but working ok for me (I do mostly JS, TS, and PHP). What @jdinhify said about the brightness is something to consider. If the palette would have even brighter colors than these, I'd use them to kind of highlight the brackets a little and make them stand out from the rest of the code. But that's a personal preference. Using darker colors makes them kinda hard to read for me, but it's also something you might get used to.

Why I'm used to brighter ones is probably because I used the VSCode default ones for quite some time as I was too lazy to change them 😄

shpigunov commented 2 years ago

Here is my proposal. #54 You can read the reasoning behind specific decisions in the PR. I will be happy to answer any questions.

jdinhify commented 2 years ago

Merged & deployed #54