Closed sgon00 closed 6 years ago
After I posted the above question (suggestion), I just found another problem. I found out the vim's gruvbox's white color is NOT really white. But this vscode's theme is truely 100% white:
Thank you very much.
Thanks @sgon00 , would you mind letting me know which language are you using? Is that golang? It'd be great if you could provide me an example of a complete file using that language (to showcase possible syntax highlighting), so that I can put into code-examples for future contributor to preview.
After having the language & example, I can change the type for that specific language like you suggested.
For the foreground color, it's not actually 100% white, it's the fg0
color in the gruvbox dark palette. But I agree, it should be the fg1
instead, I'll make this change quickly.
The foreground color has now been changed, your vscode should be able to upgrade.
CC @3ximus so that you're aware of the foreground color change
Dear @jdinhify, thank you very much for your time and quick help. Yeah, I am using golang
. The file I am using is https://github.com/dgraph-io/badger/blob/master/transaction.go . (I just randomly picked that one. )
There was no "update" button in the vscode UI. I tried to uninstall and re-install this extension, but it was still the old version. I am not sure why. so instead of the normal update process, I did:
$ cd ~/.vscode/extensions
$ rm -rf jdinhlife.gruvbox-1.1.0/
$ git clone https://github.com/jdinhify/vscode-theme-gruvbox
Thank you very much for your kind help.
@sgon00 if that didn't work you should clone elsewhere and move the cloned repo, overwriting the needed files
Thanks @3ximus .
@sgon00 hmmm, I don't feel like cloning the repo manually gonna work since you'll want the auto-upgrade ability instead of going to the cloned repo and manually pulling every time.
I'm not sure how to help you with that though, if you install the extension using vscode's UI (extensions tab), it should be upgraded automatically unless you turned it off.
Maybe just do what you're doing, but up to the 2nd step (rm -rf...
), then restart vscode and try installing the theme again.
Btw, this is what I'm having for golang:
Let me know if you think anything doesn't feel right.
@3ximus, thanks a lot for the advice.
@jdinhify,
Thank you very much for the quick fix and your hard work. The colors in your screenshot look perfect to me. :)
(Btw, maybe it's just the screenshot image, everything look bold. if they are not bold, just ignore me. )
Thank you very much!
Update: after upgrading to vscode 1.18.1, extensions can be auto-updated to latest versions. so the problem is fixed now. Cheers.
@sgon00 new version published, your vscode should be able to update to the latest one, then you can enjoy the new highlighting.
Everything is not bold, maybe just because I'm using a big font size or maybe the antialiasing makes them look bold.
@jdinhify , yeah, I updated to the latest version. It looks amazing! The best gruvbox theme in vscode. Thank you very much for the quick fix and kind help. Closing this issue.
Hi, first, thank you very much for your hard work. I really like vim's gruvbox color scheme. I just installed and tried gruvbox in vscode today. I found out it used red colors for type. In the original vim's gruvbox scheme, it's not using red color for types. I just don't like too many red colors,
Is that possible to use other colors such as yellow or orange for TYPES instead of red?
Thank you very much.