search

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
267 stars 63 forks source link

Bracket pair colorisation proposal #54

Closed shpigunov closed 2 years ago

shpigunov commented 2 years ago

This PR implements bracket pair colourisation for VS Code. I've run a few experriments that ended up informing my decisions, namely:

  1. It looks like all text colours are the same within the variations of a theme – i.e. Gruvbox Dark Soft, Medium and Hard use the same font colours. Following this logic, same bracket colours are proposed for all variations.
  2. In terms of the sequence of particular colours, the rainbow sequence seemed to make the most logical and aesthetical sense. Both Orange to Purple and Purple to Orange were tested, and the latter was found to be subjectively more readable for most language examples. Finally, red was used for unexpected/unbalanced brackets.
  3. Since Colour 2 is used for text in both Light and Dark themes, using Colour 1 makes brackets slightly distinguishable from the rest of the tokens, thus subjectively improving readability.
  4. As for the place to include the rules, they were put into the end of the editor. block.

PS: some Prettier JSON auto-formatting trickled into the files. This alters formatting but does nothing to the semantics. My apologies for that. If this turns out to be a critical issue, I will revert and re-commit. Feel free to point this out if this is the case.

jdinhify commented 2 years ago

@shpigunov please also add yourself to the end of the contributor list in package.json & README.md

shpigunov commented 2 years ago

@jdinhify done!

jdinhify commented 2 years ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: