Any plans for a light version?

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox

https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox

MIT License

274 stars 63 forks source link

Any plans for a light version? #6

Closed josebalius closed 6 years ago

josebalius commented 6 years ago

Are there any plans to do a light version?

jdinhify commented 6 years ago

Thanks Jose. I did have different versions in mind, but never got time around to try the light version and make one variant for it. Also I'm not using light version full time so I might not be the best one to implement it. The thing I had in mind was just replacing the dark colors with their corresponding light colors and hope it'll turn out alright.

Perhaps I can draft up something on the weekend and see how it goes. I'm assuming you're talking about a medium contrast theme? I'll want to make a proper one first, then the other variants will just be replacing the background colors

jdinhify commented 6 years ago

New version published with my rough draft of light versions. Please try them and let me know if there's any suggestion, or if you want to contribute.

Thank you!

josebalius commented 6 years ago

@jdinhify I will take it for a spin this week, thank you!!!

josebalius commented 6 years ago

@jdinhify So far it looks perfect, thank you again. Noticed that its missing the background color for non-selected tabs.

Here is a screenshot, I can submit a PR but not sure which setting in vscode controls this:

jdinhify commented 6 years ago

Thanks @josebalius , I noticed that too but wasn't sure which setting either, I'll have a look into vscode doco and fix it when I have time. But of course, if you found the setting and could submit a PR, it'd be great.