search

jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox
https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox
MIT License
267 stars 63 forks source link

feat: add inlay hint support #70

Open lynzrand opened 1 year ago

lynzrand commented 1 year ago

Added inlay hint color for the theme.

I'm not very sure about the color selection -- I'm currently using the color 'gray' in the color scheme as the text color for regular inlay hints, and the {color}1 version of the type and parameter color for type/parameter inlay hints.

Before: #68

After:

图片

图片

(closes #68)

lynzrand commented 1 year ago

After fixing the parameter foreground color, the inlay hints now look like this:

图片

图片

Minnozz commented 1 year ago

(Note: I am just a user of this theme, not a maintainer)

I think your changes greatly improve the visuals of inlay hints compared to master. However, I would personally prefer a bit more contrast between the background of the inlay hints and the overall background of the theme, because with this version they blend in with the "real" code a bit.

lynzrand commented 1 year ago

For me the current background works just fine, but if adding a bit of contrast makes it better I'll do that. You can test out the idea yourself by changing the line

"editorInlayHint.background": "#3c383680",

into

"editorInlayHint.background": "#3c3836",

which makes the background opaque instead of 50% transparent. I'm looking forward to your test results!

Minnozz commented 1 year ago

@lynzrand I personally prefer the version with #3c3836!

jdinhify commented 8 months ago

Thanks @lynzrand , and apologies for not being able to review this sooner 🙏

I agree with @Minnozz that I would appreciate more contrast for the inlay background, so please use the one without the alpha.

I'm keen to hear your feedback on this suggestion though: just set the inlay background, and remove the setting for all foregrounds - this will use similar color to code comments for all foregrounds. The reason is that these inlays are more "helper" type instead of real code, so I think treating them as such might make more senses?