jdinhify / vscode-theme-gruvbox

Gruvbox theme for vscode based on https://github.com/morhetz/gruvbox

https://marketplace.visualstudio.com/items?itemName=jdinhlife.gruvbox

MIT License

267 stars 63 forks source link

Added special semantic coloring for consts, readonly properties, and enums. #81

Open kronodeus opened 10 months ago

kronodeus commented 10 months ago

This PR depends upon https://github.com/jdinhify/vscode-theme-gruvbox/pull/80 because it requires semantic highlighting to be enabled.

The examples below demonstrate the changes to how constant/read-only tokens are colored. This is similar to how the modern built-in VS Code themes behave. Implementation taken from the Dark+ built-in theme. Colors taken from the original Gruvbox palette.

Before

Screenshot 2023-08-23 at 12 27 02 PM Screenshot 2023-08-23 at 12 35 02 PM

After

Screenshot 2023-08-23 at 12 26 37 PM Screenshot 2023-08-23 at 12 35 19 PM

jdinhify commented 8 months ago

@kronodeus looks like the change to overall semantics token in #83 affected how these look.

Could you please have a look again and see if you want to readjust 🙏

A suggestion is that try to use brighter colours to provide more contrast, the dark blue on dark background seems a bit lacking in contrast and make it somewhat hard to read as the result.

Bright colours for dark theme below

red2 fb4934
green2 b8bb26
yellow2 fabd2f
blue2 83a598
purple2 d3869b
aqua2 8ec07c
orange2 fe8019