search

jdisho / Papr

🌁 An Unsplash app for iOS
Apache License 2.0
1.15k stars 150 forks source link

Integrate JDToaster #88

Open jdisho opened 5 years ago

jdisho commented 5 years ago

Replace alerts with JDToaster.

artyom2206 commented 4 years ago

Can I take it?

jdisho commented 4 years ago

Yes, you can, but let’s discuss it first in this issue @artyom2206.

artyom2206 commented 4 years ago

So i installed it to Papr and implemented instead of each alertAction, but there is a problem with JDToaster on new IOS 13.2 version. When the toast shows from the bottom, then it disappears(check GIF). Toast duration also not works, I called it manually(IOS 12.4). Should I do pull request?

(https://user-images.githubusercontent.com/47772683/69388436-25c74e80-0cc9-11ea-935a-3855fe85161a.gif)

jdisho commented 4 years ago

This certainly does not look as I expected 🤔 Would you like to investigate the issue in the JDToaster and create a PR?

artyom2206 commented 4 years ago

Ok, I will look at it

jdisho commented 4 years ago

Adding a strong reference to the UIWindow will solve the issue. @artyom2206

jdisho commented 4 years ago

The issue is fixed! I will do a release soon.

Dishant10 commented 2 years ago

Hey @jdisho Is this issue already fixed ? If not I'd like to contribute on that. Let me know at the earliest.

jdisho commented 2 years ago

I don't know if this is relevant. As you may see, I'm not maintaining this app anymore 😴