search

jdliss / shoulda-callback-matchers

Test existence of your Rails callbacks without having to call them
MIT License
134 stars 18 forks source link

Allow match on array #22

Closed dvmonroe closed 8 years ago

dvmonroe commented 8 years ago

@beatrichartz any thoughts on this solution? To use without having to specify the array I thought about adding a splat to the on method argument but that would have changed a lot of other tests.

beatrichartz commented 8 years ago

Looking good, thanks for this! Will merge once travis completes.

dvmonroe commented 8 years ago

Added additional Rspec filter for rails 4 only tests in spec_helper due to previously failing tests. Curious if there is a better way with the appraisal gem?

Will squash to one commit if you're happy with the new outcome. Thanks @beatrichartz.

jdliss commented 8 years ago

@dvmonroe sorry for the really long wait! I made some changes to the travis config, could you merge master with this so the updated travis can check it?

dvmonroe commented 8 years ago

@jdliss no worries at all. Mind if we close this PR? I'll open a new one with cleaner commits after I merge master. And thanks for taking over on this gem

jdliss commented 8 years ago

@dvmonroe yeah of course. go for it

jdliss commented 8 years ago

@dvmonroe Let me know when you submit that pr, ill get it merged in when travis finishes