search

jdlrobson / WikiMaps

WikiMaps
4 stars 2 forks source link

Two edit buttons #17

Open jkan997 opened 10 years ago

jkan997 commented 10 years ago

At pages from map:namespace there are two edit buttons one leading to interactive editor and one leading to source edit. I think one of them should be renamed to have pair [EDIT][EDIT SOURCE] or [EDIT MAP][EDIT]

screen shot 2014-05-27 at 23 34 13

jdlrobson commented 10 years ago

Mmm.. most strange. The link to the wikitext editor says 'edit source' on my instance. Are you running latest MediaWiki?

jkan997 commented 10 years ago

Yes I am using newest master from GitHub, I think there will also nice to mention in README that to test this plugin MW >=1.23 is required (which is still RC)

jdlrobson commented 10 years ago

@jkan997 that is likely to be so. The extension was made in haste during a hackathon weekend so the documentation is bound to be a little nasty. Documentation will be improved when moving this to Gerrit and deploying it somewhere.

Out of interest on your instance when you install VisualEditor do you have an edit link and edit source or two edit links?

jkan997 commented 10 years ago

@jdlrobson I was on Hackhaton on WikiMaps session and saw this agile development :)

Installing Visual Editor changes situation, Edit button is renamed to Edit Source and in Map namespace we have Edit | Edit Source pair.

jdlrobson commented 10 years ago

I think the best thing to do is to merge the two editors and have one edit button to rule them all :) I have an idea how this might work and hopefully can fix this up in my experimentation time.