search

jdlrobson / WikiMaps

WikiMaps
4 stars 2 forks source link

SVG Renderer #19

Closed jkan997 closed 10 years ago

jkan997 commented 10 years ago

OK,

As you suggested:

  1. I added parameter fit="extend|box" , where extend means that renderer will try to do the best to fill the empty space and fill entire width and height (this is parametrized but not implemented yet in renderer itself -> I will this later)
  2. Renamed staticwidth, staticheight -> width, height, work both with param set and with not set (default values 800x600)
  3. Tried to configure my NB to follow code conventions http://www.mediawiki.org/wiki/Manual:Coding_conventions#Indenting_and_alignment , let me know if I have to do more
jdlrobson commented 10 years ago

Hi @jkan997 I combined all your commits into one big commit in #23 although we still need to clean some stuff up so it is in a mergeable state. I'm currently having difficult in particular working out what changed in WikiMapHelpers.php :)

jdlrobson commented 10 years ago

Let's move discussion to #23