search

jdm / asknot

Ask not what Mozilla can do for you but what you can do for Mozilla.
http://whatcanidoformozilla.org
Other
251 stars 210 forks source link

Update style.css #362

Open pchandna24 opened 4 years ago

jdm commented 4 years ago

What is the purpose of this change?

pchandna24 commented 4 years ago

I tried to change the font, because it was an issue mentioned there, to change the font to Inter.

On Mon, Oct 7, 2019, 10:00 PM Josh Matthews notifications@github.com wrote:

What is the purpose of this change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jdm/asknot/pull/362?email_source=notifications&email_token=AKEMG2UD6JXU4TFIBHV7JDLQNNPZDA5CNFSM4I6G3TN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQ7JVI#issuecomment-539096277, or mute the thread https://github.com/notifications/unsubscribe-auth/AKEMG2WSBWU6TORD4V5DXVDQNNPZDANCNFSM4I6G3TNQ .

jdm commented 4 years ago

Aha, thank you!

pchandna24 commented 4 years ago

Sure, I'll try and do that :)

On Tue, Oct 8, 2019, 12:19 AM Josh Matthews notifications@github.com wrote:

@jdm requested changes on this pull request.

In media/css/style.css https://github.com/jdm/asknot/pull/362#discussion_r332179627:

@@ -5,60 +5,65 @@

@charset "utf-8";

+@import url('https://rsms.me/inter/inter.css');

Instead of importing a remote stylesheet, can we add the font files and rules to this repository instead?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jdm/asknot/pull/362?email_source=notifications&email_token=AKEMG2WYWGSMXBZR4G2GWDTQNOACRA5CNFSM4I6G3TN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHEEECQ#pullrequestreview-298336778, or mute the thread https://github.com/notifications/unsubscribe-auth/AKEMG2VZLVFCHTBSGECNKIDQNOACRANCNFSM4I6G3TNQ .