search

jdm / bugsahoy

A landing page to make finding relevant bugs easier for new Mozilla contributors.
http://www.joshmatthews.net/bugsahoy/
69 stars 95 forks source link

Language option for github imported tasks is not reflected in filtering #71

Closed whimboo closed 10 years ago

whimboo commented 10 years ago

Today I finally checked why some of our issues on github are not displayed on the bugsahoy website, even we tagged them as mentored. As it looked like my queries has the Python or Javascript filter activated, and all of our issues do not appear. Deselecting the language filter makes them appear.

I tried to add py for python, but that didn't help. So can we please add the handling of additional tags for the language to github related projects?

Here some examples of mentored issues: https://github.com/mozilla/mozmill-ci/issues?labels=mentored&state=open

jdm commented 10 years ago

Yeah, I don't have a good solution for filtering github issues by language yet. I think it should be possible to add an optional argument to addGithubComponentMapping calls that specifies a language and update the appropriate internal data for later filtering.

whimboo commented 10 years ago

So why wouldn't that be doable via another label on that repo? I don't see that a global one would be enough, given that at least our team has hybrid projects with more than a single language used. So it would highly depend on the issue, which language to be used.

jdm commented 10 years ago

Labels would be a fine solution.

whimboo commented 10 years ago

Ok, so I did one example here: https://github.com/mozilla/mozmill-ci/issues/398

What would have to be done to get the language recognized? Is it something you could work on time-wise? Otherwise I will have to find someone. It's important for us given that most of our repos are on github and no-one asked for contribution yet. :/ Thanks.

jdm commented 10 years ago

Yes, I can implement this this week. It should not take very long.

whimboo commented 10 years ago

Wonderful. Thanks Josh!

whimboo commented 10 years ago

@jdm any news here? Next week Wednesday we will have our next big automation training day, and we would need a couple of good candidates people could work on. So seeing this fixed would help us a lot. Thanks!

jdm commented 10 years ago

Sorry for dropping the ball. I'll work on this tomorrow.

jdm commented 10 years ago

This turned out to be simpler than I expected: https://github.com/jdm/bugsahoy/commit/fd0c3e4e29705d28f0fef1bbeb8c38be3f2c3e6e

Just specify the languages and corresponding tag names for a group of repositories, and it should work. I tested it with Python and Test Automation filters enabled, and https://github.com/mozilla/mozmill-ci/issues/398 showed up in the list.

whimboo commented 10 years ago

Right now you only added Python as possible language. So I might have to come up with a follow-up patch for other languages?

jdm commented 10 years ago

Yes, since I have no idea what tags you're using in which repositories. I believe it should be evident how to add more of those based on the commit I linked, but feel free to ask more questions.

whimboo commented 10 years ago

Ok, I will get those added. I think it would be vise to use the same tags as we have on Bugzilla also for Github issues. I will create a PR with the appropriate additions.