search

jdm / bugsahoy

A landing page to make finding relevant bugs easier for new Mozilla contributors.
http://www.joshmatthews.net/bugsahoy/
69 stars 95 forks source link

Color #9

Closed caseybecking closed 12 years ago

caseybecking commented 12 years ago

Updated style and color gradient

jdm commented 12 years ago

Overlays like I am proposing in #6 might be a good way to deal with explaining the significance of the colours. Maybe they could appear if you hover over a (?) link on the right side of relevant entries or something.

caseybecking commented 12 years ago

Should I just get the whole script (magic.js) to pass jslint?

jdm commented 12 years ago

Hmm, that could be a handy tool. It seems kind of overly strict about some aspects, however, so I'm not sure I want to blindly fix everything it flags. I try to follow the Mozilla style guidelines (https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide), of which the most common and relevant are:

I'd accept a pull request that made the majority of the jslint errors go away, though I don't understand why there are results like this:

Problem at line 6 character 13: Unexpected 'in'. Compare with undefined, or use the hasOwnProperty method instead.

if (!(cat in categoryMapping))

since that's perfectly valid as far as I know.

caseybecking commented 12 years ago

Im gonna close this request and submit another one that cleans up the interface while still giving the user the info they need. i still think even that commit will need work and collaboration from both of us, but i think its a better start.

jdm commented 12 years ago

Sure. I don't mean to be a hard-ass about getting everything perfect; sorry if I'm coming across that way.

caseybecking commented 12 years ago

I would never take it that way.