search

jdmonin / JSettlers2

Java Settlers project home, downloads, and GPLv3 source code. To download the latest version as a JAR, see https://github.com/jdmonin/JSettlers2/releases/latest .
http://nand.net/jsettlers/
GNU General Public License v3.0
157 stars 63 forks source link

clicking on 'X' on the window titlebar then 'continue playing' closes the window anyway #103

Open kotc opened 3 months ago

kotc commented 3 months ago

clicking 'close window' calls the quit menu, but closes window even after pressing 'continue'. game continues on server, and can be rejoined. doesnt happen when using normal 'quit' button on the player panel.

kotc commented 3 months ago

ahm, forgot to add: os is slackware, window manager is fluxbox. also, hi! long time no see, but expect few new issues popping up shortly :)

kotc commented 3 months ago

darn those new github buttons. issue is still open :)

jdmonin commented 3 months ago

Thanks! I'll take a look this weekend

jdmonin commented 2 months ago

OK, it looks like this bug was introduced when the game window was converted to the Swing UI toolkit for v2.6.00. Under Swing, the default "Close button" automatic behavior is to hide the window (it still exists). Since we have a dialog to confirm quitting the game, the automatic behavior should be "do nothing" and have the dialog take care of it. I've tested and pushed a commit to do so.

Also, hi! it's good to see you active again :)

kotc commented 2 months ago

checked out, seems working ok

jdmonin commented 2 months ago

cool, thanks for testing the fix