search

jdmonin / JSettlers2

Java Settlers project home, downloads, and GPLv3 source code. To download the latest version as a JAR, see https://github.com/jdmonin/JSettlers2/releases/latest .
http://nand.net/jsettlers/
GNU General Public License v3.0
157 stars 63 forks source link

Status text in SOCPlayerClient is checked to have "debug" #12

Closed lartkma closed 11 years ago

lartkma commented 11 years ago

The function showStatus on SOCPlayerClient recognizes a debug message by having the word 'debug' into it (according to the docs, that includes phases such as "debugging is on"). It also appears in the status text field, so it must be localized. Annoyances with having to store part of a word aside, we can't assure all languages maintain the same root in all variations of the 'debug' word.

According to the docs, too, this can't be worked around with a status value. I'm having ideas of prefixing the debug messages with a predefined symbol or convention (like "[D]") that can be extracted before showing, but I don't know if it suit well with your design.

jdmonin commented 11 years ago

Thanks for pointing this out. We're able to send different status values to different client versions, so I clarified the docs about that.

Corrected for 2.0 with commit fc31a85 . Tested against client versions 1.1.09, 1.1.17 and 2.0.00.