search

jdmonin / JSettlers2

Java Settlers project home, downloads, and GPLv3 source code. To download the latest version as a JAR, see https://github.com/jdmonin/JSettlers2/releases/latest .
http://nand.net/jsettlers/
GNU General Public License v3.0
157 stars 63 forks source link

Update jsettlers-tables.sql #16

Closed serpro closed 9 years ago

serpro commented 9 years ago

double quotes not working in my environment (Ubuntu)

jdmonin commented 9 years ago

Thank you Sergio. Which database and version are you using?

serpro commented 9 years ago

@jdmonin I'm using MySQL 5.5.38-0ubuntu0.14.04.1 - (Ubuntu)

jdmonin commented 9 years ago

Hi Sergio,

Your request got me thinking about the bigger picture of db support. Thanks for being patient while I got that going. I've changed the SQL to be more generic, and added some notes to the READMEs. I tested against mysql, postgres, sqlite and oracle. I entirely removed the quotes, since there are no special characters in the index name. Please try the latest (commits 7ccae2b and 4b47410) and let me know if things are working for you now.

Thanks again, -Jeremy

jdmonin commented 9 years ago

Hi Sergio,

Thanks again for sending this in. If the fix I did isn't working, just let me know soon.

Thanks, -Jeremy

jdmonin commented 9 years ago

Closing this request: Other commits mentioned above fix the more general case.