Closed generateui closed 6 years ago
A ResourceSet interface introduces simplicity, safety, clarity, testability and readability.
Above arguments can be used for any type in the game (why not have ImmutablePlayer, ImmutableGame, etc... ?). ResourceSet deserves it's own since it is used a lot throughout the codebase. It's a very common concept used to implement things in JSettlers. For other classes, this advantage is (much) less so, so introducing an immutable interface definition for it is probably overkill.
That makes sense, thanks again. Merged, with followups as noted in review.