search

jdmonin / JSettlers2

Java Settlers project home, downloads, and GPLv3 source code. To download the latest version as a JAR, see https://github.com/jdmonin/JSettlers2/releases/latest .
http://nand.net/jsettlers/
GNU General Public License v3.0
157 stars 63 forks source link

update the version of java to v1.6 #49

Closed colinwerner closed 5 years ago

colinwerner commented 5 years ago

unless there is a reason to keep java 5 in there? and fix a method that was deprecated in java 8 and removed in java 9.

(Alternatively, I could have adjusted my machine, but Java 5 is no longer support by Oracle.)

jdmonin commented 5 years ago

Welcome, and thank you for your contribution :)

It's definitely time to drop java 5, and thanks for finding and fixing the method removal. I like to be as backward-compatible as possible for players with old computers, but even win xp runs java 6.

Thanks again for sending this patch!

One small reminder: For work on cloned repos and for github PRs, you'll usually want to do your work on a topic branch instead of the master branch. This lets you keep working on other things while you're waiting for your PR to be reviewed or merged. It also lets you keep tracking the upstream project's master branch, and periodically git merging master into your own branches to take advantage of improvements made upstream.