jdmonin / JSettlers2

Java Settlers project home, downloads, and GPLv3 source code. To download the latest version as a JAR, see https://github.com/jdmonin/JSettlers2/releases/latest .
http://nand.net/jsettlers/
GNU General Public License v3.0
157 stars 63 forks source link

remove cyclic dependency #54

Closed colinwerner closed 5 years ago

colinwerner commented 5 years ago

robot depends on baseclient and baseclient depends on robot, the latter of which is really unnecessary. so remove this cyclic dependency (ideally this class should be split in two as half really belongs in the robot package and the other half (ie static methods) is the base client.

jdmonin commented 5 years ago

Good catch, thanks!