A bunch of random little things

jdmonin / JSettlers2

Java Settlers project home, downloads, and GPLv3 source code. To download the latest version as a JAR, see https://github.com/jdmonin/JSettlers2/releases/latest .

http://nand.net/jsettlers/

GNU General Public License v3.0

160 stars 63 forks source link

A bunch of random little things #55

Closed colinwerner closed 5 years ago

colinwerner commented 5 years ago

static should come before final
abstract should come before static
return statements in catch blocks are redundant
remove unused import
instanceof will return false if the variable is null
remove unused parameters
remove redundant casts
remove redundant parenthesis
use a static block to init the variable
rename the constant according to Java practices
don't cache the osname

jdmonin commented 5 years ago

This is good cleanup and I appreciate it, so thanks again :) This all looks good except I want to leave MessageHandler.handleSITDOWN as-is.

jdmonin commented 5 years ago

Thanks for your persistence on this one.