search

jdneo / vscode-checkstyle

Checkstyle extension for VS Code
https://marketplace.visualstudio.com/items?itemName=shengchen.vscode-checkstyle
GNU Lesser General Public License v3.0
68 stars 15 forks source link

perf(checkstyle): Compatibility for v8.42+ #323

Closed JoseLion closed 3 years ago

JoseLion commented 3 years ago

Resolves #322

PS: I recreated the package-lock.json file because it was not compatible anymore with newer versions of NPM. However, as this can present more changes, I can remove the change from this PR 🙂

JoseLion commented 3 years ago

@jdneo I also had to update the version of maven-checkstyle-plugin to make it compatible with Checkstyle v9.0. This uncovered 25+ files with CRLF line endings, so I wanted to ask how important is the LF for the NewlineAtEndOfFile rule? Maybe it can be changed to its default value to avoid this issue moving forward 🙂

jdneo commented 3 years ago

Maybe it can be changed to its default value to avoid this issue moving forward 🙂

Yes changing to the default value looks good to me. I copied the current rule set from somewhere, and there is no need to follow every rules of it. :)

JoseLion commented 3 years ago

Awesome! That one is changed and this PR should be ready to go now 🙂

jdneo commented 3 years ago

Thank you, @JoseLion. Will take a look in this week

jdneo commented 3 years ago

Just played with this PR, everything looks good! Thank you for your contribution @JoseLion !

sbreakey commented 1 year ago

Hi. Just to clarify, we need a 1.5.0 release before checkstyle versions greater than 8.41.1 will be supported?

P.S. Thank you very much for the work on this extension!

jdneo commented 1 year ago

Oops, looks like I've made a mistake for the milestone naming. It should be already included in 1.4.1.

Let me know if there is any issue with that.

sbreakey commented 1 year ago

Ah! Yep, seems to work. Great stuff. Thanks!