jdogresorg / freewallet-desktop

Desktop wallet for Win/Mac/Linux which supports Bitcoin and Counterparty
https://freewallet.io
MIT License
67 stars 54 forks source link

Issuance Fee is ignored #166

Closed SN-Noop closed 1 year ago

SN-Noop commented 1 year ago

Final tx for issuance always use 0 for tx fee.

Using local version of FW with master.

When clicking on "Create Token" we can see this request sent to CP:

image

When clicking on "Yes" in confirm issuance we see this request:

image

Second request is indeed the one signed and broadcasted.

In red, the fee for the first request used for estimation, value in sats. In blue the fee effectively used for the final TX, value in BTC => As createIssuance do parseInt on fee parameter, you get parseInt('0.00xxx') which results to zero.

image
jdogresorg commented 1 year ago

can confirm this is an issue, and it seems CP is just using default fee if 0 is passed as fee

Thank you for reporting this issue. I will fix in next release.

jdogresorg commented 1 year ago

fixed in v0.9.24 release