Closed jdolan closed 6 years ago
cc @Paril @kaadmy
Shouldn't this mostly be a drop-in test?
Mostly. But there are probably a few new toys we can take advantage of / remove some of our own code. So with that in mind, and because 3.0.0 won't be officially released for a little while, I think it warrants a feature branch. Our early feedback would help Ryan out, too.
Also, just something to consider, I would entertain the idea of bundling PhysicsFS in deps
like we do for Minizip, given Ryan's claim of it compiling universally without any fuss. I'm not saying that's the right path, but it's something we could look at. I know that, in the past, it's been a challenge finding the latest stable release on all 3 platforms.
@jdolan can we confirm that this fixes the pak search problem?
The fix that Ryan proposed we try is in, yes. I have not yet tested it.
I will try it in a branch. Will put it in deps too.
This has been merged in #496. However, we're currently straddling the line between PhysFS 2.x and PhysFS 3.x (we're compatible with both). This is to accommodate OS X (MacPorts still not shipping PhysFS 3) and our Jenkins build slaves (Ubuntu 16.04 stuck at 2.x, Fedora 24 stuck at 2.x for MinGW as well).
Maybe in a few months, we can update fully to PhysFS 3. But, this is in now, and folks looking to build Quetoo with it can do so.
Ryan Gordon has spent a development cycle on PhysicsFS, and is planning to release 3.0.0 soon. It's available for testing as 2.1.1, or from Mercurial
HEAD
. Here's an excerpt of the beta announcement:We should probably try to get ahead of this, and cut a feature branch to test this out on all 3 platforms. It sounds like a few bugs / issues we've had with PhysicsFS (pak file enumeration, zip file rewinding, etc..) are likely fixed.