Make Soul Shard more intuitive

SoulMuncher commented 2 months ago

It's not specified anywhere that Soul Shard can only target units with less max health than the caster, besides semi-unclear floating text.
OnDrawSelected UI may be unintuitive because you only resurrect in place of one linked target, and lines are drawn to all linked targets. Maybe the closest target should have a slightly brighter colored line or something? Not sure. The actual issue may be the next point.
Clearing Soul Shard from all other affected units after resurrecting feels buggy. This was intentional for balance purposes, but should probably be reworked.
While I think resurrecting without stamina and mana is a good way to balance Soul Shard and make it a strategic spell, it's not intuitive and can lead to a lot of unexpected and feel-bad deaths. We should probably rework it.

SoulMuncher commented 2 months ago

jdoleary commented 2 weeks ago

This issue was reintroduced in https://github.com/jdoleary/Spellmasons/commit/dfb3d7e31aa9198ddfbccb77b6e2551543dd398a so we need to come up with a solution that doesn't allow for "invulnerable shard haver" if shardowner is purified. Maybe change the shard haver modifier to just not redirect damage if the target is dead?

But then what happens if they take fatal damage at the same time the owner dies and tries to resurrrect?

jdoleary / Spellmasons