jdoleary / Spellmasons

https://store.steampowered.com/app/1618380/Spellmasons/
Other
0 stars 1 forks source link

Level Up Fix #832

Closed SoulMuncher closed 1 week ago

SoulMuncher commented 1 week ago

closes #790 also fixes a bug where you would only level up once upon killing an enemy, regardless of how many levels you were eligible to gain

TODO

jdoleary commented 1 week ago

How was this tested? I'm able to level up multiple levels in master build without this change already

SoulMuncher commented 1 week ago

From what I tested on master, if you type devUnderworld.enemiesKilled = 1000, and then kill an enemy, you'll only level up once. This should never be a problem in game, since exp is 1:1 with enemies killed, but we've seen a couple exp bugs and this will handle those more smoothly. For dev purposes, it should also speed up testing things like #815 in the future

jdoleary commented 1 week ago

If you want to test leveling up you could invoke devUnderworld.reportEnemyKilled() in a loop. Setting enemiesKilled in console is not how it works in game so that's not an actual reproduction of game behavior.