jdoleary / Spellmasons

https://store.steampowered.com/app/1618380/Spellmasons/
Other
3 stars 1 forks source link

Lag when arrows deal damage #975

Open SoulMuncher opened 1 month ago

SoulMuncher commented 1 month ago

context: https://discord.com/channels/@me/1179829034100740136/1272284761938857994

SoulMuncher — Today at 3:05 PM I've noticed there's a bit of a lag spike when archers are dealing damage, any idea why this would be?

JordanO — Today at 3:05 PM maybe the new physics based projectiles?

SoulMuncher — Today at 3:06 PM Maybe, but theres a huge difference when the arrows are flying vs when they are actively colliding with a unit. It's like the game doesn't slow down until the arrow is going through a golem It could be wonky collision logic, I'm about to check but it could also be blood particles or something? curious if you had any ideas

JordanO — Today at 3:06 PM how many guys are on screen I've never had a problem with blood actually i've already optimized blood even if there's a ton of it it just reduces the number of particles so blood shouldn't be the problem but you could verify by turning off gore

SoulMuncher — Today at 3:07 PM I don't remember, it was a day or two ago and I was just thinking about it again not an absurd amount by any means no clone shenanigans which is why it stood out to me i think just a few summoners

JordanO — Today at 3:07 PM we should look into it

SoulMuncher commented 1 month ago

Related: #906 It's possible that the problem is just arrow physics and that the extra particles + damage animations only push it over the edge of lagging?

Also possibly related, on damage events optimization?: #837

SoulMuncher commented 4 weeks ago

https://github.com/user-attachments/assets/dd8965f7-dfbd-4c0f-95d8-d668a502599c