jdolitsky / AppDotNetPHP

PHP library for the App.net Stream API
34 stars 19 forks source link

Undefined variables #18

Closed edent closed 11 years ago

edent commented 11 years ago

Was getting errors Notice: Undefined variable: redirectUri in /EZAppDotNet.php on line 48

Notice: Undefined variable: scope in /EZAppDotNet.php on line 48

Here's the diff, not sure of the best way to submit it

$ diff AppDotNet.php ~/git/AppDotNetPHP/AppDotNet.php 
79d78
< global $app_redirectUri;
89c88
<               'redirect_uri'=>$app_redirectUri,

---
>               'redirect_uri'=>$this->_redirectUri,

$ diff EZAppDotNet.php ~/git/AppDotNetPHP/EZAppDotNet.php 
34c34
<       global $app_redirectUri,$app_scope;

---
> 
48c48
<       parent::__construct($clientId,$clientSecret,$app_redirectUri,$app_scope);

---
>       parent::__construct($clientId,$clientSecret,$redirectUri,$scope);
60c60
<       return parent::getAuthUrl($redirectUri);

---
>       return parent::getAuthUrl();
cdn commented 11 years ago

EZAppDotNet.php changes are in my fork.

AppDotNet.php changes are more extensive since I had an https issue and needed to include CA certificate references.

jdolitsky commented 11 years ago

we've recently had a change where you must construct getAuthUrl with redirect uri as a param instead of in the constructor. the readme unfortunately does not yet reflect this change. see here https://github.com/jdolitsky/AppDotNetPHP/issues/12 On Sep 2, 2012 4:09 AM, "cdn" notifications@github.com wrote:

EZAppDotNet.php changes are in my forkhttps://github.com/cdn/AppDotNetPHP/ .

AppDotNet.php changes are more extensive since I had an https issue and needed to include CA certificate references.

— Reply to this email directly or view it on GitHubhttps://github.com/jdolitsky/AppDotNetPHP/issues/18#issuecomment-8219871.

jdolitsky commented 11 years ago

there is a new commit coming soon, thank you for the workaround

jdolitsky commented 11 years ago

ok, please try out the latest commit. thanks for catching this.