search

jdolitsky / AppDotNetPHP

PHP library for the App.net Stream API
34 stars 19 forks source link

Whitespace 2 space vs tab? #43

Closed neuroscr closed 11 years ago

neuroscr commented 11 years ago

any one have any problems with me converting the files over to using 2 space for indentation instead of tabs?

ravisorg commented 11 years ago

BLASPHEMY!

Tabs are king! Down with the lowly space!

Seriously tho, my preference for tabs is the developer can choose however many spaces they want it to represent in the editor. So you can set your editor to display a tab of 2 spaces width, and I can (and do) set mine for 5. Conversion to spaces means that flexibility isn't there anymore. As another very slight downside, it increases file size a tad (although in this day and ago no one, including me, cares about that).

BUT! That's just me explaining why I like tabs. I leave it to the rest of the developers to vote :)

jdolitsky commented 11 years ago

Ryan, what type of issues? I've only ever had serious issues with python or cofferscript On Mar 15, 2013 6:58 AM, "ravisorg" notifications@github.com wrote:

BLASPHEMY!

Tabs are king! Down with the lowly space!

Seriously tho, my preference for tabs is the developer can choose however many spaces they want it to represent in the editor. So you can set your editor to display a tab of 2 spaces width, and I can (and do) set mine for

  1. Conversion to spaces means that flexibility isn't there anymore. As another very slight downside, it increases file size a tad (although in this day and ago no one, including me, cares about that).

BUT! That's just me explaining why I like tabs. I leave it to the rest of the developers to vote :)

— Reply to this email directly or view it on GitHubhttps://github.com/jdolitsky/AppDotNetPHP/issues/43#issuecomment-14961876 .

neuroscr commented 11 years ago

@jdolitsky no problems, it's just the default for my tools and most of my projects.

I'm open to whatever but I'd thought I'd check to see how everyone else feels about tabs.

jdolitsky commented 11 years ago

ohh, ok. wasnt aware it was a vote. I'd have to agree with @ravisorg, but as you've been working with the code most recently its your call. next person to make a commit can change it :)

ravisorg commented 11 years ago

It's not a vote, of course, it's your project, you reign supreme, I was just being diplomatic :)

jdolitsky commented 11 years ago

haha I guess, its just as much yours as mine. Make a spaces branch? lol

ravisorg commented 11 years ago

haha I guess, its just as much yours as mine. Make a spaces branch? lol

Nope, "give me power and I shall wield it!" - I hereby veto the spaces idea. Tabs it is. Sorry! :)