search

jdolitsky / AppDotNetPHP

PHP library for the App.net Stream API
34 stars 19 forks source link

Throw exception if response variable does not exist #56

Closed martinstuecklschwaiger closed 8 years ago

martinstuecklschwaiger commented 8 years ago

Sometimes the $response variable does not exist, because$this->_last_response is not truthy.

jdolitsky commented 8 years ago

Hi Martin, thanks for the fix.

I'm having trouble seeing the change. Github says 1,704 additions and 1,699 deletions and wont show the diff... guessing you or your editor reformatted the file?

Would you mind just pasting the change here in the comments?

martinstuecklschwaiger commented 8 years ago

Hi Josh, sorry for that.

Somehow the GitHub editor changed that. It's at the end of the httpReq function in AppDotNet.php line 475. 

        // else non response migration response, just return it
        else if (isset($response)) {
            return $response;
        }

        else {
            throw new AppDotNetException("No response");
        }
ravisorg commented 8 years ago

Thanks. This pull request has been integrated manually.