search

jdorn / json-editor

JSON Schema Based Editor
MIT License
5.81k stars 1.08k forks source link

Shouldn't use inline styles #223

Open vgrichina opened 10 years ago

vgrichina commented 10 years ago

For now it isn't easy to apply custom CSS styles to json-editor, because it uses inline styles heavily.

It should at very least provide at least some theme without any inline styles or better not use them at all. Custom styles should just be made available as separate CSS files.

TrevorPage commented 9 years ago

+1.

To apply my own custom CSS it seems I'm having to use !important to override the inline styles.

hdavidzhu commented 9 years ago

Is the way to edit these styles through children CSS selectors? Some divs are definitely missing class names.

dcki commented 8 years ago

+1

dcki commented 8 years ago

I think this can be done with JSONEditor.defaults.options.theme = 'barebones'

See https://github.com/jdorn/json-editor#css-integration

Can this issue be closed?

dcki commented 8 years ago

Actually, it appears that some things are still styled inline with the barebones theme, unless I'm mistaken. For example, for a field of type array, with items of type string, and uniqueItems true (i.e. a set of checkboxes), the labels have a font-weight defined inline.