search

jdorn / sql-formatter

A lightweight php class for formatting sql statements. Handles automatic indentation and syntax highlighting.
http://jdorn.github.com/sql-formatter/
MIT License
3.89k stars 187 forks source link

Added namespacing #80

Closed RonRademaker closed 8 years ago

RonRademaker commented 9 years ago

Hi, I added namespacing to the formatter. This way it won't conflict with any classnames anyone is already using and it's pretty much the way libraries are organized nowadays I think.

RonRademaker commented 9 years ago

I'm not familiair with using travis to automate testing. Why isn't it installing the phpunit dependency required by dev (which installs vendor/bin/phpunit with which the tests work fine at my end).

jdorn commented 9 years ago

This PR completely breaks backwards compatibility. There are some other breaking changes I want to make as well (remove PHP 5.2 support, method signature changes, etc.). I still need to figure out how I want to handle versioning. A lot of other projects rely on this library, so I want to be careful.

RonRademaker commented 9 years ago

I agree, adding namespaces should definitely be a major version update.