search

jdorner / node-sapnwrfc

SAP Netweaver RFC SDK bindings for Node.js
MIT License
55 stars 23 forks source link

Compile without warning on Linux and Windows #21

Closed seal-ss closed 9 years ago

seal-ss commented 9 years ago

I have rebased our changes to make compilation work on both CircleCI Linux gcc 4.9 as well as AppVeyor VS2015. Some casts broke the build on Windows. Now both platforms compile without a warning.

NilsFrkal commented 9 years ago

Hi Stefan, could you please make the compiled windows bindings available? After install I only have the sapnwrfc.node under the linux folder. Thanks.

seal-ss commented 9 years ago

@NilsFrkal you can find our build at https://github.com/plossys/node-sapnwrfc/tree/master/compiled/4.2/win32/x64

But our code is a little different from upstream. You may test our fork by adding the following to your package.json:

    "sapnwrfc": "plossys/node-sapnwrfc#0.1.10",

Compiled with node 4.2.1.

NilsFrkal commented 9 years ago

Awsome. Thank you very much.

jdorner commented 9 years ago

Fixes all build errors on windows. Thanks! The npm package 0.1.8 now ships with a Windows binary, too.

seal-ss commented 9 years ago

Great!