jdorsey2 / tournamentTracker

.net Framework
Apache License 2.0
0 stars 0 forks source link

Project organization #2

Open Maerus1 opened 3 years ago

Maerus1 commented 3 years ago

There's a few main suggestions I want to make here: 1) For the name of your namespace, you may want to make it more meaningful, I have no idea what the P and the 3 mean in P_Tracker_3 🦖 2) You need a .gitignore file to ignore any and all files/binaries that the compiler generates. I haven't done C# in a long time but this'll mean the .exe and likely both Debug folders in their entirety 3) Even though the project is small you may want to consider organizing your project. Maybe have a folder for your supplemental classes or something. 4) Don't use underscores in your variable names. C# has the "this" keyword". So if you have a member variable in a class you can reference it like: this.exists in your class. 5) I don't see any constructors, is this intentional? Eh, I guess it's fine if you just need the default constructor 6) If you want less lines of code that are still easily understood, instead of making getter/setter functions you can use auto-properties: https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/auto-implemented-properties 7) Not code related, but are you able to enable Discussions on the project? Creating an issue seems a bit cumbersome for feedback and suggestions.

I'll take a look at your code a bit later and let you know what I think 😸

Maerus1 commented 3 years ago

Here's a set of templates you can use for your .gitignore: https://github.com/github/gitignore/blob/master/VisualStudio.gitignore

Since you've already commited your bin to source control you'll need to remove them: https://git-scm.com/docs/git-rm

jdorsey2 commented 3 years ago

Should I remove all the following folders? : Properties bin/Debug obj/Debug

Maerus1 commented 3 years ago

recreate a c# project and see what files and folders it creates, that'll give you an idea as to which folders you can safely remove from your git repo