search

jdpage / w.pl

A small wiki
0 stars 1 forks source link

Different styling for external links #3

Closed jdpage closed 8 years ago

jdpage commented 8 years ago

Style external links differently from internal links.

jdpage commented 8 years ago

I was thinking something like what wikipedia has for external links, where there's a little image of an arrow after the link, but I'd prefer it to be Unicode-based rather than an image. Use your discretion.

woodrowbarlow commented 8 years ago

i'll use an iconfont. specifically, this icon. i was also thinking i'd make external links green.

jdpage commented 8 years ago

I already have mixed feelings about bringing in webfonts in the first place. What about using U+21D7 (⇗), U+2197 (↗), U+2585 (◥), U+279A (➚), or U+27B6 (➶)? Or if arrows aren't your thing, U+2042 (⁂), U+2020 (†), or even a superscripted (U+0040) (@)?

jdpage commented 8 years ago

Right now, some links that are really internal are marked as external (see #22). I know that you can probably do something clever in the CSS to deal with this, but please, PLEASE don't.

jdpage commented 8 years ago

Also, I'd be fine with just making external links green, without any icon. Dunno if you'd considered that.

jdpage commented 8 years ago

Can you please do this and #17 as a separate pull request before #10? I know you're having fun with a lot of features but it'd be nice to get some things into the codebase.