search

jdrouet / mrml

Implementation of mjml in rust
MIT License
330 stars 19 forks source link

chore: switch license to MIT #388

Closed jdrouet closed 5 months ago

jdrouet commented 5 months ago

After discussing with multiple individuals, it has come to my attention that the previous license used for this project may not have been a valid open-source license. I am considering switching to MIT, but I am open to further discussion on this topic. I will keep this pull request open for a few days to allow for input and discussion. If nobody convinces me to select another license, I will proceed with merging this update.

thibaudcolas commented 5 months ago

Great stuff! I was reviewing the package a few weeks ago and determined it wouldn’t be possible for us to use it just because of the license, as we’d be building a Python package that could reasonably be interpreted as an "email product".

mgd020 commented 5 months ago

Great stuff! I was reviewing the package a few weeks ago and determined it wouldn’t be possible for us to use it just because of the license, as we’d be building a Python package that could reasonably be interpreted as an "email product".

Check out https://github.com/mgd020/mjml-python

jdrouet commented 5 months ago

Actually mjml-python is a good implementation but doesn't implement all the mechanisms for mj-includes. If you need that feature, I also build and maintain a python library of mrml. https://pypi.org/project/mrml/

mgd020 commented 5 months ago

Actually mjml-python is a good implementation but doesn't implement all the mechanisms for mj-includes

Could you let me know which mechanisms of mj-includes are missing?

The MJML side of things is handled by MRML library, and the Python side is responsible for providing a callback function to retrieve the contents given the include name.

It doesn't include http/file out of the box, but that would be simple for the user to implement (e.g. using requests) depending on the users security/isolation level.

jdrouet commented 5 months ago

Oh, my bad, I didn't see your latest update 😊