Open JadedBlueEyes opened 3 months ago
Moving your PR to draft considering the amount of commented code and the points mentioned.
Attention: Patch coverage is 74.18398%
with 87 lines
in your changes missing coverage. Please review.
Project coverage is 92.74%. Comparing base (
5311e58
) to head (726ef4e
). Report is 61 commits behind head on main.:exclamation: Current head 726ef4e differs from pull request most recent head e67713a
Please upload reports for the commit e67713a to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This component effectively just acts as a collection of children. However, when rendered, they behave as if directly under the parent element. This is useful for passing around reusable components, etc, in Rust code.
Right now, it is not actually possible to parse a Fragment. Instead, they must be constructed by Rust code. This is because of some non-configurable validation in xmlparser: https://github.com/RazrFalcon/xmlparser/blob/e54c2768f20814140c11e6c92f94ee74bfd54808/src/stream.rs#L432
I'm using this in mrmx, as it makes it quite a bit more pleasant to use.
This might have a slight performance impact, as
fn get_children
allocates a Vector to help fold all children and nested Fragment children into one array. Before, this was directly calling.iter()
onself.element.children
. However, local benchmarking doesn't find any significant difference. I'm very much open to a different solution, though!