jdrouet / tmdb-api

Yet another TMDB api client written in rust, working with async
13 stars 8 forks source link

feat: create a Client constructor to supply the Reqwest::Client #36

Closed fusetim closed 1 year ago

fusetim commented 1 year ago

Create a new constructor with_http_client for tmdb_api::client::Client to supply the inner Reqwest::Client.

I'm not sure the name is well chosen, given the existence of with_base_url, which doesn't follow the same model. Nevertheless, I think it's the only blocking issue with this PR.

Resolve: https://github.com/jdrouet/tmdb-api/issues/35

jdrouet commented 1 year ago

👋 Thanks @fusetim for this PR. After thinking about it, I think I'd have went with a builder pattern.

fusetim commented 1 year ago

Thank you for your reply. Would this new approach suit you?

jdrouet commented 1 year ago

I did a fix and a cleanup PR in #37 😉

fusetim commented 1 year ago

Amazing, thank you 🎉