Added best practices and features

jdrouet / tmdb-api

Yet another TMDB api client written in rust, working with async

13 stars 8 forks source link

Added best practices and features #53

Closed agmbk closed 7 months ago

agmbk commented 7 months ago

I think you are missing a valid API key in your CI CD. Just saying because I plan to contribute to a fair amount to this repo in the next days and don't want to bother you with a lot of merge requests.

agmbk commented 7 months ago

Hum I guess it all went in the same pull request, I'm not really good at this :).

jdrouet commented 7 months ago

Thanks for all this! I've to find a way to fix those tests...

agmbk commented 7 months ago

I decided to make the effort to contribute instead of just adding the features on my own project. Definitely more to come as I discover edge cases or need missing api routes.

jdrouet commented 7 months ago

Thanks for that, I'll do my best to review your work ☺️