Implement `std::error::Error` for error types?

jdrouet / tmdb-api

Yet another TMDB api client written in rust, working with async

13 stars 8 forks source link

Implement `std::error::Error` for error types? #61

Closed George-Miao closed 5 months ago

George-Miao commented 5 months ago

Currently except ClientBuilderError, none of the errors are std compatible, which makes it very hard to work with crates like anyhow and eyre. It would be nice to have them implemented. I'll willing to make a PR if needed.

HakanVardarr commented 5 months ago

Why you are not using thiserror crate for errors? They can come in handy in some situations.

George-Miao commented 5 months ago

I'm writing a bin crate and won't be benefit from thiserror.

jdrouet commented 5 months ago

Fixed!