search

jdryg / vg-renderer

A vector graphics renderer for bgfx, based on ideas from NanoVG and ImDrawList (Dear ImGUI)
BSD 2-Clause "Simplified" License
519 stars 54 forks source link

VG does not discard state since bgfx commit 0881d98b #19

Closed hugoam closed 4 years ago

hugoam commented 4 years ago

bgfx::submit() old preserveState parameter has been changed to a semantically opposite meaning, it is now a discard parameter, since this commit: https://github.com/bkaradzic/bgfx/commit/0881d98bd27dd4f8fd651ca82cba29b3ce9e3d58 This causes vg-renderer to silently always preserve state, when it intends to always discard it. All instances of bgfx::submit() with two last arguments being 0, false should be fixed. (those parameters have default values, so in the future it is actually safer to omit them, to avoid a similar issue happening in the future)

hugoam commented 4 years ago

This should solve it https://github.com/jdryg/vg-renderer/pull/20