Support setting global alpha in the command lists. Also fix rendering of gradients with global alpha.

jdryg / vg-renderer

A vector graphics renderer for bgfx, based on ideas from NanoVG and ImDrawList (Dear ImGUI)

BSD 2-Clause "Simplified" License

504 stars 55 forks source link

Support setting global alpha in the command lists. Also fix rendering of gradients with global alpha. #29

Closed mcourteaux closed 3 months ago

mcourteaux commented 3 months ago

This was a missing feature when porting over from NanoVG.

Ping @bkaradzic

bkaradzic commented 3 months ago

@mcourteaux You should submit this PR to C99 branch here: https://github.com/bkaradzic/vg-renderer/tree/c99

mcourteaux commented 3 months ago

@bkaradzic What's the goal of your fork? Is it gonna get merged upstream in jdryg/vg-renderer? There is no point in maintaining two versions of the same project. Right now, jdryg/vg-renderer is still the main repository, so I don't know why you want me to make PRs into your fork? Shouldn't you just rebase/merge from upstream?

bkaradzic commented 3 months ago

What's the goal of your fork?

Already discussed here: https://discord.com/channels/712512073522872352/1234176606000648192/1235602608098381824

In short:

https://github.com/jdryg/vg-renderer/tree/c99 is the most current development branch
https://github.com/bkaradzic/vg-renderer/tree/c99 is based on c99 branch above + has changes made since, that are not public
bkaradzic/vg-renderer c99 branch will be used inside bgfx repo

mcourteaux commented 3 months ago

@jdryg Can the C99 branch and master be merged? This would make it easer for @bkaradzic to keep his fork up to date I guess.