jdtsmith / eglot-booster

Boost eglot using lsp-booster
GNU General Public License v3.0
165 stars 4 forks source link

eglot-reconnect error #10

Closed Duy-X closed 2 months ago

Duy-X commented 2 months ago

First of all, thanks for this package, it has made my experience with Eglot a lot better!

I noticed that the eglot-reconnect command errrors when eglot-booster-mode is on. I don't get an error otherwise. Please also see the backtrace below.

Happy to provide any further information if needed.

Debugger entered--Lisp error: (error "[eglot] -1: Server died")
  error("[eglot] %s" "-1: Server died")
  eglot--error("-1: Server died")
  #<subr eglot--connect>((python-mode python-ts-mode) (vc Git "~/repos/") eglot-lsp-server ("emacs-lsp-booster" "--json-false-value" ":json-false" "--" :process #f(compiled-function () #<bytecode -0x7d26266373d05f0>)) ("python" "python"))
  apply(#<subr eglot--connect> ((python-mode python-ts-mode) (vc Git "~/repos/") eglot-lsp-server ("emacs-lsp-booster" "--json-false-value" ":json-false" "--" :process #f(compiled-function () #<bytecode -0x7d26266373d05f0>)) ("python" "python")))
  eglot--connect((python-mode python-ts-mode) (vc Git "~/repos/") eglot-lsp-server (:process #f(compiled-function () #<bytecode -0x7d26266373d05f0>)) ("python" "python"))
  eglot-reconnect(#<eglot-lsp-server eglot-lsp-server-56bd125b> t)
  funcall-interactively(eglot-reconnect #<eglot-lsp-server eglot-lsp-server-56bd125b> t)
  command-execute(eglot-reconnect record)
  execute-extended-command(nil "eglot-reconnect" nil)
  funcall-interactively(execute-extended-command nil "eglot-reconnect" nil)
  command-execute(execute-extended-command)
jdtsmith commented 2 months ago

I can confirm. Just pushed a fix, give it a try?

Duy-X commented 2 months ago

Thanks for the quick fix, it works as expected now!