jdtsmith / indent-bars

Fast, configurable indentation guide-bars for Emacs
GNU General Public License v3.0
272 stars 7 forks source link

Loading a modus theme with indent-bars loaded breaks font lock #43

Closed fnurkla closed 3 months ago

fnurkla commented 3 months ago

If I run emacs -Q -l compat.el -l indent-bars.el and then in Emacs do M-x load-theme selecting one of the modus themes, I get the messages Error during redisplay: (jit-lock-function 1) signaled (void-function nil) and then funcall: Symbol’s function definition is void: nil and font lock breaks for all buffers.

This is with Emacs 30.0.5, but I also tried it with Emacs 29 when I tried to find what was causing the problem in my configuration, and that did not help.

jdtsmith commented 3 months ago

Thanks for the reproducer. For now I've disabled theme support in 6e864e0. The right solution is to factor out global faces and update those on theme loading; v0.5 will use this approach. See also #31.

fnurkla commented 3 months ago

Thank you for a quick response!

jdtsmith commented 3 months ago

v0.5 includes a new, more robust method for theme awareness. Give a try and let me know of any issues.

fnurkla commented 3 months ago

From some cursory testing it seems so be working as intended.