jdtsmith / kind-icon

Completion kind text/icon prefix labelling for emacs in-region completion
GNU Affero General Public License v3.0
174 stars 4 forks source link

Icon's too big making candidates not show fully. #40

Closed cronyakatsuki closed 10 months ago

cronyakatsuki commented 10 months ago

Hello, I have recently faced the issue where the size of the kind icon's makes it so completion candidates in corfu end up not fully shown like in the next couple screenshots.

first screnshot pic-selected-231125-1453-06

Here we can see that nineth candidate is just barelly visible.

second screenshot pic-selected-231125-1458-11

Here I have selected last candidate and as shown in the screenshot, it doens't show in popup as seen.

third screenshot pic-selected-231125-1500-03

Here I selected the candidate before the last one, that's barelly visiblel.

This issue also happens with default emacs, just that the last candidate is half visible with icons.

settings related to kind icon

(use-package kind-icon
:ensure t
:after corfu
:custom
(kind-icon-default-face 'corfu-default) ; Have background color be the same as `corfu' face background
:config
(add-to-list 'corfu-margin-formatters #'kind-icon-margin-formatter)) ; Enable `kind-icon'
cronyakatsuki commented 10 months ago

The issue mostly happens on higher font sizes

cronyakatsuki commented 10 months ago

Fixed the issue by changing the icon size, sorry for the issue.

jdtsmith commented 10 months ago

Is this an issue with corfu drawing a large enough child frame?

cronyakatsuki commented 10 months ago

From what I saw it isn't, without the icons the issue doesn't happen and on lower font size, like below <7 it also doesn't happen with icons enabled.

It might be also be a problem with my font, but at the same time the same thing happens even when I use the default font.

For now I have lowered the icon size to 0.8 and it works with no problems now.