search

jdtsmith / kind-icon

Completion kind text/icon prefix labelling for emacs in-region completion
GNU Affero General Public License v3.0
174 stars 4 forks source link

With cape.el: `Error in post-command-hook (corfu--post-command): (error "Invalid face" :icon)` #7

Closed polaris64 closed 2 years ago

polaris64 commented 2 years ago

I've just been trying the new cape.el with Corfu and when trying to complete a filename I get the error detailed in the issue title. If I remove kind-icon-margin-formatter from corfu-margin-formatters then the issue disappears.

I'm using the following versions: -

inigoserna commented 2 years ago

The error comes from line #93: (file "f" :face :icon "file-document-outline" font-lock-string-face)

":face" is misplaced there.

Maybe kind-icon (and/or corfu) should check for valid entries?

Thanks @jdtsmith and @minad for these packages!

polaris64 commented 2 years ago

Yes, I just fixed the line identified by @inigoserna and I can confirm that it works

inigoserna commented 2 years ago

kind-icon bug?

More a typo than a bug, imo.

But I think corfu or kind-icon should check for valid values.

jdtsmith commented 2 years ago

Thanks, corrected in d6c71a1.

tsdh commented 2 years ago

Could you make a bugfix release on ELPA?

jdtsmith commented 2 years ago

It should have been updated several weeks ago. Just in case I bumped the version.

tsdh commented 2 years ago

Yeah, I think ELPA requires a new version number in order to make a new release. Thank you!

jdtsmith commented 2 years ago

1.1.3 is published on ELPA, thanks for the reminder.