search

jdtuck / ElasticFDA.jl

Functional Data Analysis using Square-Root Slope Framework
Other
10 stars 5 forks source link

Change REQUIRES file to Project.toml #7

Open tecosaur opened 3 years ago

tecosaur commented 3 years ago

Hi, I'm interested in using this package but have issues installing it which I believe are related to the use of the REQUIRES file, which has been deprecated for the three years now.

Symbolics and Meshes both require RecipesBase version 1.0-1.1. ElasticFDA's REQUIRES seems to imply a v0.4-0.8 restriction for some reason

 ├─restricted by compatibility requirements with ElasticFDA [f9e31aca] to versions: 0.4.0-0.8.0, leaving only versions: 0.5.0-0.8.0

I think changing out the REQUIRES for a Project.toml would be quite nice, both for me installing this package, for long-term stability, and future compatibility with Julia's Pkg.

If it's of any help I've been able to find a discussion on Julia's discourse about this: https://discourse.julialang.org/t/convert-require-to-project-toml-and-manifest-toml/17775

tecosaur commented 3 years ago

Ah, I seem to have been looking in the wrong place for why this was happening:

https://github.com/JuliaRegistries/General/blob/bf2a0455bec8ecbe6fc7acb9ab62b6885a967855/E/ElasticFDA/Compat.toml#L10

["0.5.1-0"]
RecipesBase = "0.0.0 - 0.8"

Unfortunately, this also means that v0.5 is installed over v0.5.2. Separately from changing the REQUIRES to a Package.toml, could this restriction be loosened / extended to newer versions of RecipiesBase?

jdtuck commented 3 years ago

I have not had time to work on this package lately, I will see what I can do.

tecosaur commented 3 years ago

If you could that would be grand, the problem seems to be that a lot of major libraries have moved on with their dependencies, so trying to install this package causes version conflicts during dependency resolution. I was able to get it to manually install by hand-editing the Compat.toml cloned on my computer, and it seemed to work, but that was wiped the next package operation I did.

So, if you might be able to just upgrade the dependency versions (IIRC I actually ended up needing to change more than just RecipesBase, but I forget what), that would be absolutely great :slightly_smiling_face:. A Package.toml would be nice, but that ends up being tangential to the dependency versions issue.