jdtuck / fdasrsf_python

elastic fda python code
http://research.tetonedge.net
BSD 3-Clause "New" or "Revised" License
52 stars 18 forks source link

Question: Why is this repo using the tarballs from https://anaconda.org/scientific-python-nightly-wheels/openblas-lib? #36

Closed mattip closed 7 months ago

mattip commented 8 months ago

I am refactoring the openblas-libs build to change the name of the shared object in the tarballs at https://anaconda.org/scientific-python-nightly-wheels/openblas-lib, and this repo turned up in a code search to see who else is using it. This repo is downloading it when building wheels via the openblas_support.py script. But my search foo is not good enough to see where in the code openblas is actually used, and what will break when the new tarballs go live. Could you help me out?

vnmabus commented 7 months ago

Is this maybe related to #37?

mattip commented 7 months ago

Maybe? It seems there is a package called crbfgs that is failing to import. I see it in the cython sources https://github.com/jdtuck/fdasrsf_python/blob/33dab0a9d46ea5c82f77b9e38c69eccd9aad8cc5/src/crbfgs.pyx#L3

But I don't see that in your requirements and cannot find a reference to it in PyPI.

vnmabus commented 7 months ago

I will mention @jdtuck, just in case he did not read this issue.

jdtuck commented 7 months ago

@mattip it will not break anything and thank you for checking. It is used in a local CI setup. Don't worry about breaking that. Also not related to #37